Show impact of a possible ResolutionStrategy implementation #5891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return builder.toString(); | ||
| } | ||
|
|
||
| public NearestWins addRequirement(String requested) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public NearestWins addRequirement(String requested) { | |
| @Override | |
| public NearestWins addRequirement(String requested) { |
| } | ||
| } | ||
|
|
||
| protected @Nullable String cacheResolved(DownloadOperation<Iterable<String>> availableVersions) throws MavenDownloadingException { |
Contributor
There was a problem hiding this comment.
Suggested change
| protected @Nullable String cacheResolved(DownloadOperation<Iterable<String>> availableVersions) throws MavenDownloadingException { | |
| @Override | |
| protected @Nullable String cacheResolved(DownloadOperation<Iterable<String>> availableVersions) throws MavenDownloadingException { |
| import java.util.HashSet; | ||
| import java.util.Iterator; | ||
| import java.util.Set; | ||
| import java.util.stream.Collectors; |
Contributor
There was a problem hiding this comment.
Suggested change
| import java.util.stream.Collectors; | |
| import static java.util.stream.Collectors.joining; |
|
|
||
| @Override | ||
| public String toString() { | ||
| return requestedVersions.stream().map(Object::toString).collect(Collectors.joining(", ")); |
Contributor
There was a problem hiding this comment.
Suggested change
| return requestedVersions.stream().map(Object::toString).collect(Collectors.joining(", ")); | |
| return requestedVersions.stream().map(Object::toString).collect(joining(", ")); | |
| @Override |
| return new SoftRequirement(requested); | ||
| } | ||
|
|
||
| protected @Nullable String cacheResolved(DownloadOperation<Iterable<String>> availableVersions) throws MavenDownloadingException { |
Contributor
There was a problem hiding this comment.
Suggested change
| protected @Nullable String cacheResolved(DownloadOperation<Iterable<String>> availableVersions) throws MavenDownloadingException { | |
| @Override | |
| protected @Nullable String cacheResolved(DownloadOperation<Iterable<String>> availableVersions) throws MavenDownloadingException { |
| @@ -0,0 +1,6 @@ | |||
| package org.openrewrite.maven.tree; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| package org.openrewrite.maven.tree; | |
| /* | |
| * Copyright 2025 the original author or authors. | |
| * <p> | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * <p> | |
| * https://www.apache.org/licenses/LICENSE-2.0 | |
| * <p> | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ | |
| package org.openrewrite.maven.tree; |
| @@ -0,0 +1,387 @@ | |||
| package org.openrewrite.maven.tree; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| package org.openrewrite.maven.tree; | |
| /* | |
| * Copyright 2025 the original author or authors. | |
| * <p> | |
| * Licensed under the Apache License, Version 2.0 (the "License"); | |
| * you may not use this file except in compliance with the License. | |
| * You may obtain a copy of the License at | |
| * <p> | |
| * https://www.apache.org/licenses/LICENSE-2.0 | |
| * <p> | |
| * Unless required by applicable law or agreed to in writing, software | |
| * distributed under the License is distributed on an "AS IS" BASIS, | |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| * See the License for the specific language governing permissions and | |
| * limitations under the License. | |
| */ | |
| package org.openrewrite.maven.tree; |
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| } |
Contributor
|
This PR is stale because it has been open for 90 days with no activity. Remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
What's changed?
After the previous PR we've mentioned implementation of something like a
ResolutionStrategywould come in handy for later purposes. This PR adds the ResolutionStrategiesNewest_WinsandNearest_Wins.Anyone you would like to review specifically?
@sambsnyd
Any additional context
If we want to support Gradle specific behavior further, we should still have to add support for a
VersionSpecthat is able to work with+.Checklist